Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 152: Added string template cell #161

Merged
merged 11 commits into from
Feb 12, 2021

Conversation

Siemienik
Copy link
Owner

@Siemienik Siemienik commented Feb 12, 2021

resolves #152

A lot of this code is the same as in #160. I'll refactor it somewhen in the future.

image

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #161 (ca62af4) into master (caf8796) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        54    +1     
  Lines         1036      1061   +25     
  Branches       146       153    +7     
=========================================
+ Hits          1036      1061   +25     
Flag Coverage Δ
xlsx-import 100.00% <ø> (ø)
xlsx-renderer 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/xlsx-renderer/src/CellTemplatePool.ts 100.00% <100.00%> (ø)
packages/xlsx-renderer/src/cell/NormalCell.ts 100.00% <100.00%> (ø)
...kages/xlsx-renderer/src/cell/TemplateStringCell.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf8796...ca62af4. Read the comment docs.

@Siemienik Siemienik merged commit be07a88 into master Feb 12, 2021
@Siemienik Siemienik deleted the feature/152-template-string-cell branch February 12, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TemplateStringCell: Allow to mix dynamic values (variables) with static values in the same cell.
1 participant